<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 4, 2012, at 1:48 PM, Blue Swirl wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Tue, Dec 4, 2012 at 1:25 AM, Programmingkid<br><<a href="mailto:programmingkidx@gmail.com">programmingkidx@gmail.com</a>> wrote:<br><blockquote type="cite"><br></blockquote><blockquote type="cite">On Dec 3, 2012, at 3:13 PM, Mark Cave-Ayland wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On 30/11/12 20:14, Programmingkid wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">What do you mean when you say something is whitespace damaged?<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">It's a general term for formatting changes that don't affect the patch, e.g.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">for (i = 0; i <= 10; i++) {<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">to<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">for (i = 0; i <= 10; i++)<br></blockquote><blockquote type="cite">{<br></blockquote><br>Please take a look at this example for non-wanted style changes. Don't<br>just ignore what others are telling you.<br><br><blockquote type="cite"><br></blockquote><blockquote type="cite">It means that the patch includes non-functional changes which is generally<br></blockquote><blockquote type="cite">frowned upon.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">What section do I not need? Could you give me the first and last line of<br></blockquote><blockquote type="cite">this section? I need the actual text since the line number will probably not<br></blockquote><blockquote type="cite">help if our files are different.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">See below.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- } else {<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- /* Another partition was explicitly requested */<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ // if no partition and no file was selected - example: "dir cd:,\"<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ else if (parnum == -1)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ {<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ // search for the first partition of type Apple_HFS or Apple_HFSX<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ for(parnum = 1; parnum<= __be32_to_cpu(par.pmMapBlkCnt); parnum++)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ {<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ SEEK( bs * parnum );<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ READ(&par, sizeof(par) );<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ DPRINTF("found partition type: %s with status %x\n",<br></blockquote><blockquote type="cite">par.pmPartType, __be32_to_cpu(par.pmPartStatus));<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ if(strcmp(par.pmPartType, "Apple_HFS") == 0 ||<br></blockquote><blockquote type="cite">strcmp(par.pmPartType, "Apple_HFSX") == 0)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ {<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ offs = (long long)__be32_to_cpu(par.pmPyPartStart) * bs;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ size = (long long)__be32_to_cpu(par.pmPartBlkCnt) * bs;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ goto found;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ break;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ // Another partition was explicitly requested<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ else<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ {<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">ATB,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Mark.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Ok this patch removes the unneeded code and remotes the whitespace damage.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">signed-off-by: John Arbuckle <<a href="mailto:programmingkidx@gmail.com">programmingkidx@gmail.com</a>><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Index: trunk/openbios-devel/packages/mac-parts.c<br></blockquote><blockquote type="cite">===================================================================<br></blockquote><blockquote type="cite">--- trunk/openbios-devel/packages/mac-parts.c (revision 1075)<br></blockquote><blockquote type="cite">+++ trunk/openbios-devel/packages/mac-parts.c (working copy)<br></blockquote><blockquote type="cite">@@ -164,16 +164,12 @@<br></blockquote><blockquote type="cite"> for (parnum = 1; parnum <= __be32_to_cpu(par.pmMapBlkCnt); parnum++) {<br></blockquote><blockquote type="cite"> SEEK( bs * parnum );<br></blockquote><blockquote type="cite"> READ( &par, sizeof(par) );<br></blockquote><blockquote type="cite">- if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE ||<br></blockquote><blockquote type="cite">- !__be32_to_cpu(par.pmPartBlkCnt) )<br></blockquote><blockquote type="cite">- break;<br></blockquote><blockquote type="cite">-<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite"> DPRINTF("found partition type: %s with status %x\n", par.pmPartType,<br></blockquote><blockquote type="cite">__be32_to_cpu(par.pmPartStatus));<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- /* If we have a valid, allocated and readable partition... */<br></blockquote><blockquote type="cite">- if( (__be32_to_cpu(par.pmPartStatus) & kPartitionAUXIsValid) &&<br></blockquote><blockquote type="cite">- (__be32_to_cpu(par.pmPartStatus) & kPartitionAUXIsAllocated) &&<br></blockquote><blockquote type="cite">- (__be32_to_cpu(par.pmPartStatus) & kPartitionAUXIsReadable) ) {<br></blockquote><blockquote type="cite">+ // If an Apple_HFS or Apple_HFSX partition was found<br></blockquote><blockquote type="cite">+ if(strcmp(par.pmPartType, "Apple_HFS") == 0 || strcmp(par.pmPartType,<br></blockquote><blockquote type="cite">"Apple_HFSX") == 0)<br></blockquote><blockquote type="cite">+ {<br></blockquote><br>Here's one case where you have changed the brace style.<br><br><blockquote type="cite"> offs = (long long)__be32_to_cpu(par.pmPyPartStart) * bs;<br></blockquote><blockquote type="cite"> size = (long long)__be32_to_cpu(par.pmPartBlkCnt) * bs;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">@@ -181,9 +177,11 @@<br></blockquote><blockquote type="cite"> if (want_bootcode && (__be32_to_cpu(par.pmPartStatus) &<br></blockquote><blockquote type="cite">kPartitionAUXIsBootValid)) {<br></blockquote><blockquote type="cite"> offs += (long long)__be32_to_cpu(par.pmLgBootStart) * bs;<br></blockquote><blockquote type="cite"> size = (long long)__be32_to_cpu(par.pmBootSize);<br></blockquote><blockquote type="cite">-<br></blockquote><blockquote type="cite"> goto found;<br></blockquote><blockquote type="cite">- } else {<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">+ else<br></blockquote><blockquote type="cite">+ {<br></blockquote><br>Another, don't change '} else {'.<br><br><blockquote type="cite"> /* Otherwise we were passed a filename and path. So let's<br></blockquote><blockquote type="cite"> choose the first partition with a valid filesystem */<br></blockquote><blockquote type="cite"> DPUSH( offs );<br></blockquote><blockquote type="cite">@@ -196,9 +194,11 @@<br></blockquote><blockquote type="cite"> }<br></blockquote><blockquote type="cite"> }<br></blockquote><blockquote type="cite"> }<br></blockquote><blockquote type="cite">-<br></blockquote><blockquote type="cite">- } else {<br></blockquote><blockquote type="cite">- /* Another partition was explicitly requested */<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">+ // Another partition was explicitly requested<br></blockquote><br>And here you changed the comment style to C99. Don't do that.<br><br><blockquote type="cite">+ else<br></blockquote><blockquote type="cite">+ {<br></blockquote><br>Another unwanted change.<br><br>Please take a more care to follow the style, consistency is important<br>in software projects. Ignoring review comments will lead to ignored<br>patches.<br><br><blockquote type="cite"> SEEK( bs * parnum );<br></blockquote><blockquote type="cite"> READ( &par, sizeof(par) );<br></blockquote><blockquote type="cite"><br></blockquote></div></blockquote><br></div><div><br></div><div>Here is an updated patch with the above issues fixed.</div><div>Signed-off-by : John Arbuckle <<a href="mailto:programmingkidx@gmail.com">programmingkidx@gmail.com</a>></div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">Index: trunk/openbios-devel/packages/mac-parts.c</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">===================================================================</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">--- trunk/openbios-devel/packages/mac-parts.c<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 1075)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">+++ trunk/openbios-devel/packages/mac-parts.c<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">@@ -164,16 +164,10 @@</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>for (parnum = 1; parnum <= __be32_to_cpu(par.pmMapBlkCnt); parnum++) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>SEEK( bs * parnum );</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>READ( &par, sizeof(par) );</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE ||</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">- !__be32_to_cpu(par.pmPartBlkCnt) )</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>break;</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>DPRINTF("found partition type: %s with status %x\n", par.pmPartType, __be32_to_cpu(par.pmPartStatus));</div><p style="margin: 0.0px 0.0px 0.0px 0.0px; font: 11.0px Menlo; min-height: 13.0px"> <br class="webkit-block-placeholder"></p><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>/* If we have a valid, allocated and readable partition... */</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>if( (__be32_to_cpu(par.pmPartStatus) & kPartitionAUXIsValid) &&</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>(__be32_to_cpu(par.pmPartStatus) & kPartitionAUXIsAllocated) &&</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>(__be32_to_cpu(par.pmPartStatus) & kPartitionAUXIsReadable) ) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">+<span class="Apple-tab-span" style="white-space:pre"> </span>/* If an Apple_HFS or Apple_HFSX partition was found */</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">+<span class="Apple-tab-span" style="white-space:pre"> </span>if(strcmp(par.pmPartType, "Apple_HFS") == 0 || strcmp(par.pmPartType, "Apple_HFSX") == 0) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>offs = (long long)__be32_to_cpu(par.pmPyPartStart) * bs;</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>size = (long long)__be32_to_cpu(par.pmPartBlkCnt) * bs;</div><p style="margin: 0.0px 0.0px 0.0px 0.0px; font: 11.0px Menlo; min-height: 13.0px"> <br class="webkit-block-placeholder"></p><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">@@ -196,9 +190,7 @@</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>}</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>}</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>}</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>} else {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">-<span class="Apple-tab-span" style="white-space:pre"> </span>/* Another partition was explicitly requested */</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">+<span class="Apple-tab-span" style="white-space:pre"> </span>} else {<span class="Apple-tab-span" style="white-space:pre"> </span>/* Another partition was explicitly requested */</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>SEEK( bs * parnum );</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span class="Apple-tab-span" style="white-space:pre"> </span>READ( &par, sizeof(par) );</div><p style="margin: 0.0px 0.0px 0.0px 0.0px; font: 11.0px Menlo; min-height: 13.0px"> <br class="webkit-block-placeholder"></p><div><br></div></div><br></body></html>