<html><body>
<p><tt>Stefan Reinauer <stepan@coresystems.de> wrote on </tt><tt>Fri Aug 18 17:43:44 CEST 2006</tt><tt><br>
<br>
> * Stefan Reinauer <stepan@coresystems.de> [060818 17:06]:<br>
> . . . . .<br>
> <br>
> For a quick test I ran a coverage test with our new and shiny test suite <br>
> and here's the results:<br>
> <br>
> Code covered: 95.9 %<br>
> <br>
> That is pretty damn good for a first run. Even if it was a safety<br>
> critical applications.<br>
> <br>
> The whole coverage report can be checked here:<br>
> <a href="http://openbios.org/~stepan/toke/coverage/fcode-utils/toke/index.html">http://openbios.org/~stepan/toke/coverage/fcode-utils/toke/index.html</a><br>
> <br>
> As you can clearly see most of the files only have their panic code<br>
> uncovered. Which is pretty normal. Only whats wrong with strsubvocab.c<br>
> ;-)<br>
> <br>
> David, thank you very much for this high quality contribution.<br>
> <br>
> Stefan<br>
> <br>
> -- <br>
> coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.<br>
> Tel.: +49 761 7668825 • Fax: +49 761 7664613<br>
> Email: info@coresystems.de • <a href="http://www.coresystems.de/">http://www.coresystems.de/</a><br>
</tt><br>
<br>
<tt>Stefan Reinauer <stepan@coresystems.de> wrote on 09/05/2006 12:04:09 PM:<br>
<br>
> Dear David,<br>
> <br>
> thank you for the conference call and the nice conversation.<br>
> <br>
> Please go ahead and send the next round of toke files with a <br>
> bumped version number, so that people can see the progress being made.<br>
> <br>
> I will merge the changes into the new tree.<br>
> <br>
> Stefan<br>
</tt><br>
<br>
I have completed the changes we discussed and will be sending them to you separately.<br>
<br>
The coverage report identified several areas of "dead code" (most notably in strsubvocab.c ) as well as a few cases that weren't covered in the Test Suite.<br>
<br>
I changed the Test Suite to fill those gaps (there are now 167 tests, as counted by the AutoExec script) and removed the dead routines (except for one I believe should remain for possible future use -- read the top of the Data Stack without popping it off). I also fine-tuned some error detection in "User-defined command-line compilation-control symbols" (when attempting to access a defined value, distinguish between the case where no value is assigned to the symbol versus where the symbol is altogether undefined; and identify multiple definitions of the same symbol).<br>
<br>
And, as we spoke, I bumped the version number to 1.0.01<br>
<br>
I then ran my own coverage test; it showed a satisfactory improvement. I will not be sending you my results; your independent confirmation would be preferable.<br>
<br>
One other thing I'd like to request. I think the Coverage Report is a Very Good Thing: it deserves to be displayed prominently, not just mentioned in an item in the Mail Archives. When you complete your coverage test, could you open up an additional section -- like the sections for "Unit-Test Suite" and "Unit-Test Suite Logs" -- for it, at the end of the "OpenBIOS - FCode suite" page?<br>
<br>
Thanks.<br>
<br>
-----<br>
<br>
David L. Paktor System Firmware Developer<br>
System and Technology Group Global Firmware Division<br>
dlpaktor@us.ibm.com David L Paktor/Almaden/IBM@IBMUS<br>
<br>
18880 Homestead Rd. Building 9945<br>
Cupertino CA 95014 Room 1026<br>
408-342-6110 T/L 560-6110<br>
<br>
"The Bug Stops Here"<br>
</body></html>