[OpenBIOS] [PATCH] ppc: fix mtmsr for SF setting

Alexander Graf agraf at suse.de
Sat Jun 18 01:00:44 CEST 2011


On 17.06.2011, at 21:43, Andreas Färber wrote:

> Am 17.06.2011 um 00:14 schrieb Alexander Graf:
> 
>> When running openbios-ppc32 on a ppc64 VM, we need to unset SF on every
>> interrupt to ensure that things still work.
>> 
>> So far we've been using mtmsr for this operation, but according to the
>> spec mtmsr doesn't set any bit above 32bit, so we were merely exploiting
>> a bug in qemu before.
>> 
>> This patch adds a runtime check on PVR to see if we're running on a 64-bit
>> capable CPU. If so, we use mtmsrd, which can set the high 32bits of MSR.
>> 
>> CC: Andreas Färber <andreas.faerber at web.de>
>> Signed-off-by: Alexander Graf <agraf at suse.de>
>> ---
>> arch/ppc/qemu/start.S |   50 +++++++++++++++++++++++++++++++++++++++++-------
>> 1 files changed, 42 insertions(+), 8 deletions(-)
> 
> I don't spot the difference? Was this a resend by mistake?
> 
> You seem to have committed a different version incorporating Segher's suggestion without posting it first and waiting for Acks.

Hrm, you're right. I must have messed something up there - sorry :).


Alex




More information about the OpenBIOS mailing list