[OpenBIOS] [PATCH 1/2] CIF: Emit debug linebreak when method fails

Blue Swirl blauwirbel at gmail.com
Tue Sep 28 21:40:16 CEST 2010


On Tue, Sep 28, 2010 at 7:32 PM, Mark Cave-Ayland
<mark.cave-ayland at siriusit.co.uk> wrote:
> Andreas Färber wrote:
>
>> When DEBUG_CIF is defined, a serial message of the form "method(...) = "
>> is emitted by dump_service(). After successful execution the return value
>> and a linebreak are emitted by dump_return(). If however the method fails,
>> nothing is emitted, so that subsequent method calls end up in place of the
>> return value. Observed for getproplen with AIX.
>>
>> Emit an error indication and a linebreak when DEBUG_CIF is defined.
>
> These two patches look good to me too - Blue, any objections?

They look OK, I just forgot about them.



More information about the OpenBIOS mailing list