[OpenBIOS] [HaikuPorts-devs] [PATCH] fcode-utils: Add type support for Haiku

François Revol revol at free.fr
Mon Sep 20 14:38:45 CEST 2010


Le 19 sept. 2010 à 22:10, Stefan Reinauer a écrit :

> On 9/19/10 7:11 PM, Andreas Färber wrote:
>> Haiku does not have asm/types.h. It does have [u]int*_t but not
>> in sys/types.h. Use stdint.h instead, that works for both Haiku and
>> OpenSolaris and avoids more code duplication in shared/types.h.
>> 
>> Signed-off-by: Andreas Färber<andreas.faerber at web.de>
>> Cc: Stefan Reinauer<stepan at openbios.org>
> 
> Thanks for spotting this and sending a patch!
> 
> Hm.. I'm just wondering... shouldn't we instead use stdint.h for all platforms? It's there at least on all C99 compilers (see section 7.18).. I think we can stop caring too much for platforms with more than 10yr old compilers (that, in addition, don't come with stdint.h anyways)

As I said already, it's stdint.h which should typedef those according to POSIX.
So it'd be logical to make it the default and only exclude platforms that don't conform on this.

François.


More information about the OpenBIOS mailing list