[OpenBIOS] [PATCH 06/10] pci: bus scan amendment

Igor Kovalenko igor.v.kovalenko at gmail.com
Wed May 26 22:49:43 CEST 2010


On Thu, May 27, 2010 at 12:24 AM, Igor Kovalenko
<igor.v.kovalenko at gmail.com> wrote:
> On Wed, May 26, 2010 at 11:02 PM, Blue Swirl <blauwirbel at gmail.com> wrote:
>> On Tue, May 25, 2010 at 12:38 PM, Igor V. Kovalenko
>> <igor.v.kovalenko at gmail.com> wrote:
>>> From: Igor V. Kovalenko <igor.v.kovalenko at gmail.com>
>>>
>>> - refactor scan procedure to start with PCI host controller
>>> - initiate scan of subordinate PCI bus from PCI host and PCI-to-PCI bridges
>>> - find out PCI subordinate bus numbers and write them to bride devices
>>> - automated assignment of "reg", "ranges", and "bus-range" properties
>>
>> Unfortunately this breaks the PPC Mac99 machine.
>>
>> To test, simply run 'qemu-system-ppc -M mac99', the screen remains
>> black. 5/10 still works.
>>
>
> The expectation to have host PCI bridge at pci0:0:0 is invalid, mac99
> has it at device 0xb
> The following change attached hereto fixes that by adding a scan for
> host bridge.
>
> It would be great if you could include it into the set after currently
> failing one, thanks!

Unfortunately there is a typo in ob_pci_read_identification, it must
check pointers before assignment, not data pointed to. It does not
produce errors in my -M mac99 test but breaks sparc64 test.

Please check the updated version attached. I now tested
qemu-system-sparc64 and qemu-system-ppc -M mac99 with updated version.

-- 
Kind regards,
Igor V. Kovalenko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: of-pci-host-bridge-scan-20100527-2.patch
Type: application/octet-stream
Size: 4534 bytes
Desc: not available
URL: <http://lists.openbios.org/pipermail/openbios/attachments/20100527/c5cca3fa/attachment.obj>


More information about the OpenBIOS mailing list