[OpenBIOS] r117 - openbios-devel/drivers
Stefan Reinauer
stepan at coresystems.de
Mon Apr 9 14:20:20 CEST 2007
* Blue Swirl <blueswir1 at hotmail.com> [070407 21:49]:
> >> if (size > OBIO_CMDLINE_MAX) size = OBIO_CMDLINE_MAX;
> >> memcpy(obio_cmdline, nv_info.cmdline, size);
> >> - obio_cmdline[size-1] = '\0';
> >> + obio_cmdline[size] = '\0';
> >
> >Looks like you need to change the declaration of
> >"obio_cmdline[]" or the maximum value "size" is
> >clamped to, as well?
>
> Good point. The attached untested patch should fix the overflow possibility.
applied in r119.
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
More information about the OpenBIOS
mailing list